Every call of settings.instance.db_engine() synchronizes the local sqlite file with cloud. If the session is stored, then this synchronization doesn't happen anymore.

Ahhh, thanks for the hint! I moved this logic over to lndb-setup and I'll think what to do about this!

My current thought is that the main thing this means is that we need to mutual exclusion check for the sqlite file. And we might need more control for influencing synching for the user.

The problem with storing the session is that the db file is synchronized only once on session initialization. Actually, this change might break a lot of things. For example, if the cached db file is deleted, it won't be synchronized anymore as far as i understand.

Yes, I see. It’s an experimental change that’s deeply grounded in how users should experience lazily loading sqlalchemy objects.

I’ll walk you through it. And if there is another solution, then that’d be great.

To note: In the current implementation, the old behavior (function-scoped sessions) is just an environment variable away. So, we can just switch it back anytime.

What happens with the stored session when the cached db file is deleted? Or replaced? Maybe it is better to initiate sync of the db file on every session() call. If it doesn't break the session, then it is prob the solution.

We can do that, with some caveats; let’s try scoping both the session and the cache check with the InstanceSession lifetime (which is essentially until call of lndb_setup.init) for one day or two, and then talk about mutual exclusion and updates in the sqlite case in depth

Mutual exclusion is not meaningful in this setting, because we don't get any changes from the cloud until new init call where new session is received.
I mean this change seems to break the sync logic totally.

🚀 Deployed on https://637e4333acf33a0a44a9c3b3--lamindb-qnwk.netlify.app